Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Install the grpc packages instead of binary tar. #8

Merged
merged 1 commit into from
Dec 7, 2015

Conversation

ivannaranjo
Copy link
Contributor

This change installs the gRPC library directly from packages and the release at github instead of using the checked in tar file with binaries. After this PR is merged the images will be a self-contained Dockerfile that can download all the necessary dependencies and building the images will be a single docker build . command.
This change also formats the code a bit better to hopefully make it a bit more readable.

This should close issue #6

@ivannaranjo
Copy link
Contributor Author

//cc @jskeet @mmdriley

@ivannaranjo
Copy link
Contributor Author

To note, these packages are the latest packages and as such they might not work. In doing this work I also opened the issue #31 in the grpc-docker-libary repo as their Dockerfile are no longer building, seems like the package they referring to, libgrpc0 has a different version and the Dockerfile has not been updated.

zip \
zlib1g \
-y --force-yes --no-install-recommends
# The GRPC backports version is different because the package in jesse-backport's version is different.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different from what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the other version :), will fix.

@mmdriley
Copy link

mmdriley commented Dec 4, 2015

lgtm modulo above

ivannaranjo added a commit that referenced this pull request Dec 7, 2015
Install the grpc packages instead of binary tar.
@ivannaranjo ivannaranjo merged commit b252808 into master Dec 7, 2015
@ivannaranjo ivannaranjo deleted the install_grcp_from_package branch December 7, 2015 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants