Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue-3631): updating deps manually with high confidence rating (part 1) #3639

Closed
wants to merge 3 commits into from
Closed

fix(issue-3631): updating deps manually with high confidence rating (part 1) #3639

wants to merge 3 commits into from

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Mar 8, 2024 •
edited
Loading

Description

Refactoring from #3631 (update all deps) PR from dependabot.

Manually splitting out dependency updates according to confidence (mergeability) rating to manage any unexpected test failures incrementally.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. api: appengine Issues related to the App Engine Admin API API. api: auth api: automl Issues related to the AutoML API. api: batch Issues related to the Batch API. api: cloudasset Issues related to the Cloud Asset Inventory API. api: cloudsql Issues related to the Cloud SQL for MySQL API. api: language Issues related to the Cloud Natural Language API API. asset: pattern DEE Asset tagging - Pattern. labels Mar 8, 2024
@pattishin pattishin mentioned this pull request Mar 8, 2024
Closed
1 task
@pattishin pattishin marked this pull request as ready for review March 8, 2024 22:00
@pattishin pattishin requested review from a team as code owners March 8, 2024 22:00
@pattishin pattishin requested review from a team as code owners March 8, 2024 22:00
@pattishin pattishin closed this Apr 24, 2024
@pattishin pattishin deleted the fix/issue-3631-deps branch April 24, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtskinner holtskinner holtskinner approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. api: appengine Issues related to the App Engine Admin API API. api: auth api: automl Issues related to the AutoML API. api: batch Issues related to the Batch API. api: cloudasset Issues related to the Cloud Asset Inventory API. api: cloudsql Issues related to the Cloud SQL for MySQL API. api: language Issues related to the Cloud Natural Language API API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pattishin @holtskinner @jping0220