-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generativeaionvertexai_gemini_translate #3887
Open
gryczj
wants to merge
2
commits into
main
Choose a base branch
from
text-translation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+129
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
samples
Issues that are directly related to samples.
api: genai
labels
Sep 27, 2024
gryczj
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
kokoro:run
Add this label to force Kokoro to re-run the tests.
labels
Sep 27, 2024
gryczj
force-pushed
the
text-translation
branch
from
September 27, 2024 13:53
c451af1
to
e74d4b3
Compare
kokoro-team
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Sep 27, 2024
subfuzion
approved these changes
Sep 27, 2024
gryczj
force-pushed
the
text-translation
branch
2 times, most recently
from
September 30, 2024 10:49
e7b882e
to
752f96b
Compare
gryczj
changed the title
feat: aiplatform_gemini_translate
feat: generativeaionvertexai_gemini_translate_gemini_translate
Sep 30, 2024
gryczj
changed the title
feat: generativeaionvertexai_gemini_translate_gemini_translate
feat: generativeaionvertexai_gemini_translate
Sep 30, 2024
gryczj
force-pushed
the
text-translation
branch
from
September 30, 2024 10:57
752f96b
to
09f824d
Compare
gryczj
commented
Sep 30, 2024
@@ -37,6 +37,6 @@ describe('Generative AI Stream MultiModal with Image', () => { | |||
`node ./sendMultiModalPromptWithImage.js ${projectId} ${location} ${model}` | |||
); | |||
// Ensure that the conversation is what we expect for these images | |||
assert(output.match(/city: Rio de Janeiro, Landmark: Christ the Redeemer/)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gryczj
force-pushed
the
text-translation
branch
from
September 30, 2024 11:33
b16237c
to
96b5ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.