Update build script with lint warnings #404

WilsonkwSheng · 2024-09-30T06:37:45Z

Install ESLint by Microsoft in VSCode to display the warnings in IDE. Can configure further to auto fix if needed.

Set to display lint warnings instead of stopping the next cmd

… upper-cased Object

Reason is it is still easy to read and does not introduce too many whitespacing

…pression

Due to process.exit will return early need add eslint-disable-next-line no-unreachable

…erator-runtime dependency

…iable issues Resolved ESLint warnings related to undefined browser-specific variables Ensured compatibility for both Node.js and browser environments in the project

…pression

Include whitespacing, comma, use const instead of let, reorder function first before variable is used, remove unnecessary else statement, adding semicolon

…ability

Include whitespacing, comma, use const instead of let, reordering function first before variable is used, add semicolon

Include whitespacing, add semicolon, reordering function first before variable is used, add semicolon

It is being used in other files except the current file where is being defined

Explicitly cast yargs.parse() result to 'Answers' type using 'as unknown as Answers' for improved type safety

- reason is because it does not serve much purpose for now but in the future where linting will need to be enforced then change here

WilsonkwSheng force-pushed the chore/update-build-and-lint-script branch 4 times, most recently from ab6b595 to 33a3d8d Compare October 2, 2024 09:32

WilsonkwSheng force-pushed the chore/update-build-and-lint-script branch 2 times, most recently from d5eaa50 to c687a26 Compare October 23, 2024 12:56

shioju mentioned this pull request Oct 26, 2024

chore: add types #411

Draft

6 tasks

Wilson WeeSheng Khoo added 23 commits October 30, 2024 09:54

Update build script with lint warnings

2a455ab

Set to display lint warnings instead of stopping the next cmd

Reorder and remove unused methods from import packages

2e53288

Fix prefer using the primitive object as a type name, rather than the…

f5b0ce0

… upper-cased Object

Resolve variable was used before it was defined

1ec83fe

Remove unused variables

4e5a1e0

Disable lines-between-class-members rule

4bc8f23

Reason is it is still easy to read and does not introduce too many whitespacing

Use const instead of let

9065a8b

Fix whitespacing linting

b7e929c

Resolve expected an assignment or function call and instead saw an ex…

dbf9d29

…pression

Resolve assignment to property of function parameter 'argvs'

db986df

Resolve the warning of adding break before case statement

23e575b

Due to process.exit will return early need add eslint-disable-next-line no-unreachable

Resolve unexpected lexical declaration in case block

3981889

Resolve unexpected string concatenation

9e17ad5

Refactor logger transport configuration for improved readability

88e2f34

Rename __filename to filename for consistency with modern ESM syntax

69cf2fb

Add comma for linting purpose

e9b7fde

Use || for better readability

442cfe3

Fix whitespacing issues

18f4721

Refactor: Replace for...of loops with array iterations to avoid regen…

e33ce4f

…erator-runtime dependency

Add browser environment to ESLint configuration to resolve global var…

8a7c6df

…iable issues Resolved ESLint warnings related to undefined browser-specific variables Ensured compatibility for both Node.js and browser environments in the project

Use method shorthand to resolve unnamed method and ESLint warnings

b8ee26c

Fix using variable first before method is defined

ccf01c9

Avoid reassignment of function parameter to comply with ESLint rules

58b2e6b

Wilson WeeSheng Khoo added 28 commits October 30, 2024 09:54

Removed unnecessary parentheses around a single parameter

193d5fd

Add semicolon

6f555d6

Use const instead of let

5f7c576

Resolve expected an assignment or function call and instead saw an ex…

1e4a58a

…pression

Remove unnecessary return statement

9937190

Replace == with === for strict equality checks

5c57a1f

Fix eslint warnings for crawlIntelligentSitemap

52a9ee7

Include whitespacing, comma, use const instead of let, reorder function first before variable is used, remove unnecessary else statement, adding semicolon

Chain with else if

199a1d8

Reformatted function parameters across multiple lines for better read…

73c287a

…ability

Use object destructuring to simplify variable assignment

9ee74ff

Separated the destructuring which will be reassigned and const

be8267f

Fix eslint warnings for htmlScreenshotFunc

9c658c9

Include whitespacing, comma, use const instead of let, reordering function first before variable is used, add semicolon

Fix eslint warnings for pdfScreenshotFunc

b4c3e8d

Include whitespacing, add semicolon, reordering function first before variable is used, add semicolon

Replace != with !== for strict equality checks

75b97f2

Wrap eslint-disable for no-unused-vars warning

8c2f640

It is being used in other files except the current file where is being defined

Resolve variable name conflict

ab7dd7b

Remove unsued variable

f77a23d

Remove redundant use of await inside Promise.all

42e021b

Remove unnecessary variable assignment from RequestList.open

b2635c5

Use const instead of let

c84773a

Replace unary increment operator with += 1

ee03b82

Change to default export to resolve ESLint warning

31368b0

Refactor option handling for type safety and cleaner syntax

9971e1d

Explicitly cast yargs.parse() result to 'Answers' type using 'as unknown as Answers' for improved type safety

Using export default for single class

833781e

Update type of any to string[] for getWcagPassPercentage function

7d5fc4c

Intentionally disable no-await-in-loop warning for retryFunction

f9bc506

Using export default for single class

199e63d

Remove lint from build

959f7ad

- reason is because it does not serve much purpose for now but in the future where linting will need to be enforced then change here

WilsonkwSheng force-pushed the chore/update-build-and-lint-script branch from c687a26 to 959f7ad Compare October 30, 2024 01:57

WilsonkwSheng merged commit 259e55c into master Oct 30, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update build script with lint warnings #404

Update build script with lint warnings #404

WilsonkwSheng commented Sep 30, 2024 •

edited

Loading

Update build script with lint warnings #404

Update build script with lint warnings #404

Conversation

WilsonkwSheng commented Sep 30, 2024 • edited Loading

WilsonkwSheng commented Sep 30, 2024 •

edited

Loading