Try to improve table readability #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, thanks @MTRNord! I'll try to give it a test tonight just for sanity, and then I can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this is better or worse tbh. The ellipsis via CSS dynamically only works for a single line which is also not great, hence done in R which equally is not great.
Additionally, the scrollbar imho happens way too late in the table as well. But since it's a table cell, it's not possible to override it's cell height.
There are ways to use grid + divs but this is not a div table and tbh accessiblity-wise that's not great.
TLDR: Table CSS still sucks in 2023 but at least this doesn't massively overflow anymore and it scrolls on mobile.