Add png icon support for browsers that don't support svg files #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request includes changes suggested by @juyrjola (ernoma@692bb05). As @tuukka requested, there is now the icon task to generate png icons from svg icons only if there has been changes in the images directory. This might look a bit hack but it works well and maybe in future grunt will include a good way to do this (see: gruntjs/grunt#851). Also, as @tuukka requested the class="citynavicon-myicon" is only applied after page has been created when iconprovider.modify_img_elements() is called. Icons now correctly show on Windows 8 phone. Tested with Nokia Lumia 520.