Canary mismatches are no longer fatal exceptions, they simply return …

…the correct value so their callers can abandon work.
Hammerspoon · Mar 9, 2022 · 1348219 · 1348219
1 parent 3bca009
commit 1348219
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/LuaSkin/LuaSkin/Skin.m b/LuaSkin/LuaSkin/Skin.m
@@ -346,15 +346,17 @@ - (BOOL)checkGCCanary:(LSGCCanary)canary {
     NSLog(@"checkGCCanary (%@) comparing %@ vs %@", [NSThread.callStackSymbols objectAtIndex:1], self.uuid.UUIDString, NSlsCanary);
 #endif
     if (!NSlsCanary || ![self.uuid.UUIDString isEqualToString:NSlsCanary]) {
-        NSLog(@"LuaSkin caught an attempt to operate on an object that has been garbage collected.");
-        for (NSString *stackSymbol in [NSThread callStackSymbols]) {
-            NSLog(@"Previous stack symbol: %@", stackSymbol);
-        }
-        NSException* myException = [NSException
-                                    exceptionWithName:@"LuaGCCanaryMismatch"
-                                    reason:[NSString stringWithFormat:@"GC Canary changed: Expected %@, found %@", self.uuid.UUIDString, NSlsCanary]
-                                    userInfo:nil];
-        @throw myException;
+        // Throwing an exception is not helpful in production, because the whole point of the canary check is to discard events that are being delivered to stale Lua instances.
+        // We can hang onto the code anyway in case we need it later.
+//        NSLog(@"LuaSkin caught an attempt to operate on an object that has been garbage collected.");
+//        for (NSString *stackSymbol in [NSThread callStackSymbols]) {
+//            NSLog(@"Previous stack symbol: %@", stackSymbol);
+//        }
+//        NSException* myException = [NSException
+//                                    exceptionWithName:@"LuaGCCanaryMismatch"
+//                                    reason:[NSString stringWithFormat:@"GC Canary changed: Expected %@, found %@", self.uuid.UUIDString, NSlsCanary]
+//                                    userInfo:nil];
+//        @throw myException;
         return NO;
     }