Remove wasm #14
Merged
Remove wasm #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zo-el
reviewed
Sep 9, 2024
src/deriveSeedFrom.js
Outdated
Comment on lines
8
to
37
| function deriveSeedFrom(hha_id, email, password) { | ||
| throw new Error("javascript deriveSeedFrom is not implemented yet") | ||
|
|
||
| // return new Uint8Array([ | ||
| // 224, 186, 208, 19, 196, 26, 72, 30, | ||
| // 72, 91, 170, 129, 169, 229, 53, 112, | ||
| // 216, 149, 4, 192, 1, 114, 148, 173, | ||
| // 14, 68, 215, 72, 242, 209, 155, 196 | ||
| // ]) | ||
|
|
||
| let salt = sha512.digest(email) | ||
|
|
||
| // const seed = argon2.hash({ | ||
| // pass: password, | ||
| // salt, | ||
| // type: argon2.ArgonType.Argon2id | ||
| // }) | ||
|
|
||
| // { | ||
| // // optional | ||
| // time: 1, // the number of iterations | ||
| // mem: 1024, // used memory, in KiB | ||
| // hashLen: 24, // desired hash length | ||
| // parallelism: 1, // desired parallelism (it won't be computed in parallel, however) | ||
| // secret: new Uint8Array([...]), // optional secret data <- hha_id | ||
| // ad: new Uint8Array([...]), // optional associated data | ||
| // } | ||
|
|
||
| return seed | ||
| } |
There was a problem hiding this comment.
I think I am missing something here, I am seeing everything commented here
src/index.js
Outdated
| deriveSeedFrom | ||
| } = require("@holo-host/wasm-key-manager"); | ||
| } = require("./deriveSeedFrom") | ||
| const KeyManager = require("./keyManager") |
There was a problem hiding this comment.
I thought we decided not to have this implementation in the lib.
we should have have two implementation, lets just remove it and if we need it then they should use the wasm-key-manager
There was a problem hiding this comment.
I was just keeping the half completed js implementations around. But I'll move them to a branch
zo-el
reviewed
Sep 9, 2024
package.json
Outdated
Comment on lines
23
to
25
| "@noble/ed25519": "^2.1.0", | ||
| "@noble/hashes": "^1.5.0", | ||
| "argon2-browser": "^1.18.0", |
There was a problem hiding this comment.
we should remove the unnecessary modules too
zo-el
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency on
@holo-host/wasm-key-managerwas causing down stream build issues with this module in some environments, so I removed it. That repo is still available to be imported directly.