Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering previously registered holoport creates stale entries in ZT Central #55

Merged
merged 6 commits into from
Feb 11, 2022

Conversation

zo-el
Copy link
Member

@zo-el zo-el commented Feb 4, 2022

Solution for Issue #47

Copy link
Contributor

@alastairong alastairong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I am a little worried about adding more calls to ZT in a Cloudflare worker since I don't have a good feeling about its reliability.

Can you add more console.log lines so that we can debug the worker live if necessary?

Cloudflare workers have live logging, but ONLY for console.log not other types of logs

server/src/routes/zt_registration.js Outdated Show resolved Hide resolved
server/src/routes/zt_registration.js Outdated Show resolved Hide resolved
server/src/routes/zt_registration.js Outdated Show resolved Hide resolved
Copy link
Contributor

@alastairong alastairong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving since I'm sure logs with be fine :)

@alastairong alastairong merged commit ce67b9d into develop Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants