Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test runner setup and fix failing tests #115

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Fix test runner setup and fix failing tests #115

merged 3 commits into from
Mar 26, 2024

Conversation

mattyg
Copy link
Contributor

@mattyg mattyg commented Oct 23, 2023 •
edited
Loading

  • Replace jest with vitest
  • Fixes mocking browser globals
  • Fixes failing tests

Resolves #108

@mattyg
Copy link
Contributor Author

mattyg commented Oct 23, 2023

@robbiecarlton

@mattyg mattyg marked this pull request as draft October 23, 2023 20:15
@mattyg mattyg mentioned this pull request Oct 24, 2023
Closed
@mattyg mattyg marked this pull request as ready for review March 24, 2024 21:35
@mattyg
Copy link
Contributor Author

mattyg commented Mar 24, 2024

@robbiecarlton please can we get this reviewed and merged?

@mattyg mattyg mentioned this pull request Mar 24, 2024
Merged
3 tasks
@robbiecarlton robbiecarlton merged commit 467a989 into Holo-Host:develop Mar 26, 2024
1 check passed
@mattyg mattyg deleted the build/fix-tests-replace-jest branch March 27, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbiecarlton robbiecarlton robbiecarlton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests failing on develop with SyntaxError: Unexpected token 'export'
2 participants
@mattyg @robbiecarlton