buildozer 4.0.0 + simplified build process #70924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
go
SMillerDev
reviewed
Feb 11, 2021
Comment on lines
+26
to
+36
| (dir/"go.mod").write <<~EOS | ||
| module github.com/bazelbuild/buildozer | ||
| go 1.15 | ||
| require ( | ||
| github.com/bazelbuild/buildtools v0.0.0-20210208125002-752270cf2f52 | ||
| github.com/golang/protobuf v1.4.3 // indirect | ||
| google.golang.org/protobuf v1.25.0 // indirect | ||
| ) | ||
| EOS | ||
|
|
||
| (dir/"go.sum").write <<~EOS |
There was a problem hiding this comment.
We do not want to maintain these in the formula, please submit them upstream.
There was a problem hiding this comment.
Then please remove buildozer, buildifier and charm-tools from being tested when a new go version is released.
Go 1.15.8 is being held hostage by packages that fail because of unrelated reasons to go.
|
I made #71330 to disable these, they're not worth the maintenance effort of rolling our own go.mod files etc |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently buildozer fails to build and blocks #70446 and #70143 from moving forward.
The reason buildozer fails is the same reason described in #70921.
This update increases the version to 4.0.0 but also simplifies the build process.
The build no longer depends on bazelisk which should simplify things in the future.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?