Unified Dev Server #1105
Open
Unified Dev Server #1105
+5,297
−274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsines
requested review from
brandenrodgers,
camden11,
kemmerle and
joe-yeager
as code owners
tenas97
approved these changes
Nov 20, 2024
TanyaScales
approved these changes
Nov 21, 2024
| @@ -207,12 +239,6 @@ exports.builder = yargs => { | |||
| type: 'string', | |||
| requiresArg: true, | |||
| }); | |||
| yargs.option('notify', { | |||
There was a problem hiding this comment.
Technically removing this makes it a breaking change. We're queuing up a major release in the next branch. If you merge this into that branch it should make getting this out alongside everything else nice and easy.
brandenrodgers
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Adds unified dev server dependency behind a gate, plan is to have both dev servers in this release and then once we ungate 100% we'll remove the other one. Removes a few command args that either aren't implemented / won't get used going forward.
Some changes I had to do around node version here to set it to 20 to be friendly with the cms-dev-server dependency that may need correcting if this won't work with the rest of the CLI.