fix!: Wrap Axios type and export new type #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-yeager
commented
Nov 14, 2024
http/index.ts
Outdated
| @@ -16,6 +16,8 @@ import { HubSpotHttpError } from '../models/HubSpotHttpError'; | |||
|
|
|||
| const i18nKey = 'http.index'; | |||
|
|
|||
| export type HubSpotResponse<T = unknown> = AxiosPromise<T>; | |||
There was a problem hiding this comment.
This is the primary change, all of the others are reactionary.
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
kemmerle
approved these changes
Nov 20, 2024
camden11
reviewed
Nov 20, 2024
| @@ -16,6 +16,8 @@ import { HubSpotHttpError } from '../models/HubSpotHttpError'; | |||
|
|
|||
| const i18nKey = 'http.index'; | |||
|
|
|||
| export type HubSpotPromise<T = unknown> = AxiosPromise<T>; | |||
There was a problem hiding this comment.
LDL currently defines all types within the types dir, so this should live in types/http
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Wraps the
AxiosPromisein aHubSpotPromisetype and exports it so that integrators don't need to useReturnTypeannotations to have access to the type.