Add support for gathering proc files necessary to convert coredump to minidump #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swermin
force-pushed
the
feat/include-proc-info
branch
from
426280b
to
849d539
Compare
Signed-off-by: Ermin Hrkalovic <[email protected]>
Signed-off-by: Ermin Hrkalovic <[email protected]>
Signed-off-by: Ermin Hrkalovic <[email protected]>
Signed-off-by: Ermin Hrkalovic <[email protected]>
Signed-off-by: Ermin Hrkalovic <[email protected]>
swermin
force-pushed
the
feat/include-proc-info
branch
from
849d539
to
5c6f2a0
Compare
|
@swermin quick update to let you know I'll get to the review over the next few days. |
|
Sounds great, I am available anytime to answer and makes changes as needed! |
Signed-off-by: Ermin Hrkalovic <[email protected]>
|
Update - Looks like I'm back as repo admin - Thanks @jjasghar |
|
Hi @No9, have you had a chance to go through these changes? 😄 |
No9
approved these changes
Aug 8, 2024
|
Thanks for the reminder - been very busy for the past few weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running breakpads core2md out-of-process requires some files from the /proc/$pid folder to be able to successfully generate enough information.
This change enables gathering of those said files to be able to support that flow. It is hidden behind a feature flag and its disabled by default so that the behavior of the composer is same as before.
This feature is ment to grab the minimum files needed to be able to generate minidumps. So heap data will be omitted and such.