-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isReleased to collection DvObjectOwnerNode. #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Please remember: |
IQSS/dataverse#10882 should be tested and merged before this one |
removed the Waiting tag, since the Dataverse issue has been merged |
Updated |
@ekraffmiller could you review again? I have changed the dataverse image to |
@g-saracca Where are the functional tests for this PR? |
@ofahimIQSS Oh, I didn't think it was necessary to validate the isPartOf field in a functional test since it was already being tested through an integration test, that's why there are none. |
As discussed in the Front-end standup, did visual inspection of the code, no issues observed. Additional ticket to be opened to track adding of integration tests for this ticket. |
What this PR does / why we need it:
Adds
isReleased
to collectionDvObjectOwnerNode
.Which issue(s) this PR closes:
Related Dataverse PRs:
Suggestions on how to test this:
Visual inspection of code and github action executions