Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isReleased to collection DvObjectOwnerNode. #199

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Oct 1, 2024

What this PR does / why we need it:

Adds isReleased to collection DvObjectOwnerNode.

Which issue(s) this PR closes:

Related Dataverse PRs:

Suggestions on how to test this:

Visual inspection of code and github action executions

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset View Page GREI Re-arch GREI re-architecture-related SPA.Q3.6 Publish Collection FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) Original size: 10 labels Oct 1, 2024
@ekraffmiller ekraffmiller self-assigned this Oct 3, 2024
ekraffmiller
ekraffmiller previously approved these changes Oct 3, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@g-saracca
Copy link
Contributor Author

Please remember:
⚠️ Environment variables should be changed to unstable image tag before merging into develop. IQSS/dataverse#10882 should be merged before applying this change.

@ofahimIQSS ofahimIQSS self-assigned this Oct 7, 2024
@ofahimIQSS ofahimIQSS removed their assignment Oct 7, 2024
@g-saracca
Copy link
Contributor Author

g-saracca commented Oct 7, 2024

IQSS/dataverse#10882 should be tested and merged before this one

@ekraffmiller
Copy link
Contributor

removed the Waiting tag, since the Dataverse issue has been merged

@ofahimIQSS ofahimIQSS self-assigned this Oct 9, 2024
@GPortas GPortas added SPA.Q4 Not related to any specific Q4 feature and removed SPA.Q3.6 Publish Collection labels Oct 9, 2024
@g-saracca
Copy link
Contributor Author

Updated .env dataverse image to unstable since the Dataverse related issue has been merged.

@g-saracca
Copy link
Contributor Author

@ekraffmiller could you review again? I have changed the dataverse image to unstable, thanks!

@ofahimIQSS
Copy link
Contributor

@g-saracca Where are the functional tests for this PR?

@g-saracca
Copy link
Contributor Author

@ofahimIQSS Oh, I didn't think it was necessary to validate the isPartOf field in a functional test since it was already being tested through an integration test, that's why there are none.

@cmbz cmbz added the FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) label Oct 9, 2024
@ofahimIQSS
Copy link
Contributor

As discussed in the Front-end standup, did visual inspection of the code, no issues observed. Additional ticket to be opened to track adding of integration tests for this ticket.

@ofahimIQSS ofahimIQSS merged commit 1913993 into develop Oct 10, 2024
5 checks passed
@ofahimIQSS ofahimIQSS deleted the 194-isReleased-to-DvObjectOwnerNode branch October 10, 2024 16:25
@ofahimIQSS ofahimIQSS removed their assignment Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) GREI Re-arch GREI re-architecture-related Original size: 10 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset View Page SPA.Q4 Not related to any specific Q4 feature
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Add 'isReleased' to DvObjectOwnerNode, for collections when returning owners
5 participants