Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quirk in overview display when using external controlled variables #11005

Open
bjosel opened this issue Nov 7, 2024 · 4 comments · May be fixed by #11034
Open

Quirk in overview display when using external controlled variables #11005

bjosel opened this issue Nov 7, 2024 · 4 comments · May be fixed by #11034
Labels
Type: Bug a defect

Comments

@bjosel
Copy link

bjosel commented Nov 7, 2024

What steps does it take to reproduce the issue?
Add some JS-script and configure ":CVocConf" in order to select entries from external vocabularies or id-providers

  • When does this issue occur?
    When looking at the metadata in the metadata tab

  • Which page(s) does it occurs on?
    On the dataset overview page

  • What happens?
    Some entries that have been filled via selecting from external sources are shown repeatedly.

  • To whom does it occur (all users, curators, superusers)?
    Happens to all users

  • What did you expect to happen?
    The entries should be displayed only once

Which version of Dataverse are you using?
6.4

Screenshots:
Author names and project title are shown repeatedly
ohnePatch_alteOrcid_mitFooter

If we apply a small patch author names and project title are displayed correctly
mitPatch_altesOrcid_mitFooter

Are you thinking about creating a pull request for this issue?
Yes, we can create a PR. Our patch would be the following:

Screenshot from 2024-11-07 15-58-42

This effectively changes the logic of the decision if data is rendered from NOT(ITEM1 AND ITEM2) to NOT(ITEM1 OR ITEM2). All test so far didn't expose any side effects of the patch

@bjosel bjosel added the Type: Bug a defect label Nov 7, 2024
@qqmyers
Copy link
Member

qqmyers commented Nov 7, 2024

Thanks for the report and possible fix. FWIW: I think our most recent testing has been done using authorsOrcidAndRor.json, which works as can be seen for doi:10.70122/FK2/NEQHTE. Can you make sure your fix works for that case as well?

@bjosel
Copy link
Author

bjosel commented Nov 7, 2024

Yes, we tested with the latest authorsOrcidAndRor.json, too. It works with our patch, see the screenshot
mitPatch_neuesOrcid_mitFooter

@DS-INRAE
Copy link
Member

Great! Would you be willing to make the PR to contribute your patch then ? :)

@DS-INRAE DS-INRAE moved this to 🔍 Interest in Recherche Data Gouv Nov 19, 2024
@ffritze
Copy link

ffritze commented Nov 19, 2024

A pull-request has been created: #11034

@qqmyers qqmyers linked a pull request Nov 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect
Projects
Status: 🔍 Interest
Development

Successfully merging a pull request may close this issue.

4 participants