Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display overview fix #11034

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

ffritze
Copy link

@ffritze ffritze commented Nov 19, 2024

What this PR does / why we need it:
On the metadata page there can be duplicated / redundant metadata entries. This pull-request fixes an IF-clause in metadataFragment.xhtml to eliminate the redundant display of metadata fields

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: (from Jim) - see the issue - looks like you can see the issue if you configure the ORCID script but not the ROR script via the external vocabulary mechanism (https://github.com/gdcc/dataverse-external-vocab-support/blob/main/examples/authorIDandAffilationUsingORCIDandROR.md describes adding both, the ROR script can be dropped by removing the JSON object for the ROR script).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good. I added some testing notes - feel free to add/change. I also ask that you remove the entry in the API change log (since it is API only). I'm looking into the build failure - it's a known issue not related to the PR contents.

@@ -7,6 +7,10 @@ This API changelog is experimental and we would love feedback on its usefulness.
:local:
:depth: 1

v6.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for API changes so I don't think we want an entry here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the release note is enough. Thanks!

@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Nov 19, 2024
@pdurbin pdurbin added the Type: Bug a defect label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect
Projects
Status: In Review 🔎
Development

Successfully merging this pull request may close these issues.

Quirk in overview display when using external controlled variables
3 participants