Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published datasets should contain files #10994

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

stevenwinship
Copy link
Contributor

What this PR does / why we need it: The existing publishing model in HDV allows the publishing of datasets without files. This lends to the curation team contacting depositors about uploading files via support and often to deleting "empty" datasets.

To decrease the support contact and dataset deletions, change the publishing model to require all deposits contain at least one file before publishing can happen.

Which issue(s) this PR closes:#10981

Special notes for your reviewer:

Suggestions on how to test this: See the added IT test

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: Included

Additional documentation:

@stevenwinship stevenwinship self-assigned this Oct 31, 2024
@stevenwinship stevenwinship added Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) labels Oct 31, 2024
@stevenwinship stevenwinship force-pushed the 10981-published-datasets-should-contain-files branch from d5bb6c2 to 85af55f Compare November 1, 2024 17:04

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Nov 1, 2024
@coveralls
Copy link

Coverage Status

coverage: 21.854% (-0.002%) from 21.856%
when pulling 8cfa938 on 10981-published-datasets-should-contain-files
into b28812b on develop.

Copy link

github-actions bot commented Nov 6, 2024

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10981-published-datasets-should-contain-files
ghcr.io/gdcc/configbaker:10981-published-datasets-should-contain-files

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@cmbz cmbz added the FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) Size: 30 A percentage of a sprint. 21 hours. (formerly size:33)
Projects
Status: Ready for Review ⏩
Development

Successfully merging this pull request may close these issues.

Publishing: Published datasets should contain files
4 participants