Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about v8 not being supported #15

Merged
merged 2 commits into from
Mar 18, 2024
Merged

docs: add note about v8 not being supported #15

merged 2 commits into from
Mar 18, 2024

Conversation

nihalgonsalves
Copy link
Contributor

Thanks for this plugin – it worked (works) really well to bring Turbosnap to Storybook 7.

I'd like to add this note here because it's confusing if you don't see the migration note - Storybook will disable the plugin and the Turbosnap CI step will fail. I came to this repo first to see if there were any open issues, and only later noticed that the correct way was to use the new --stats-json Vite support instead.

@IanVS
Copy link
Owner

IanVS commented Mar 18, 2024

Thanks for the PR!

@IanVS IanVS merged commit 3c62cb2 into IanVS:main Mar 18, 2024
1 check passed
@nihalgonsalves nihalgonsalves deleted the patch-1 branch March 19, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants