Handle binary and non-jms header names #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onyxraven
commented
Jul 7, 2022
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| <!-- <plugin>--> |
There was a problem hiding this comment.
couldn't get this plugin to behave, so commented for now
src/main/java/com/amazon/sqs/javamessaging/message/SQSMessage.java
Outdated
Show resolved
Hide resolved
| import com.amazon.sqs.javamessaging.SQSMessagingClientConstants; | ||
| import com.amazon.sqs.javamessaging.SQSQueueDestination; | ||
| import com.amazon.sqs.javamessaging.acknowledge.Acknowledger; | ||
| import com.amazonaws.services.sqs.model.MessageAttributeValue; | ||
| import org.apache.commons.logging.LogFactory; |
| } else if (BINARY.equals(type)) { | ||
| // if Binary, getBinaryValue() should be used but should require an userland mapper | ||
| // it must map to one of Boolean, Byte, Short, Integer, Long, Float, Double, and String. | ||
| // TODO userland mapper, but for now we're just going to log and skip it. The key won't be added |
sanimalp
approved these changes
Aug 30, 2022
Agreed, I think ultimately this is a placeholder while we test, and make available for manual builds. I wouldn't publish the artifacts of this one directly. I am going to refactor for the v2 release of the library and craft a real PR with upstream. |
onyxraven
changed the title
|
Closing this for now, we have an internal branch of this, and will likely refactor for v2 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request uses a branch-fork from the last aws-sdk v1 tag from the upstream library. We can use this branch to maintain any fixes until all v1 uses are deprecated and removed.
These changes should be able to port forward to the v2 branch at a later date.
The JMS consumer has a couple gotchas that can cause un-rescuable issues when consuming SQS messages from outside sources.
This PR tackles the following issues:
\wword characters)\Wregex)Relevant upstream tickets:
Similar: