Allow reference of optical path for annotations measurements #194
Conversation
* Minor fixes to segmentation * Fix docstring typo in type
* Fix recording of evidence in structured reports * Assert that evidence is provided for references * Use sets for comparison and avoid duplicates * Add test for report referencing multiple studies * Use datetime workaround for python 3.6 support * Added image_library_entries to TID 1500 Co-authored-by: Sean Doyle <[email protected]> Co-authored-by: hackermd <[email protected]> Co-authored-by: Christopher Bridge <[email protected]>
There was a problem hiding this comment.
This looks good to me except one minor error I spotted. Though if I remember correctly, we were waiting on a decision about changes to the standard?
There are some changes in this PR that I think we should have in master now, regardless of what happens to the optical path stuff. Specifically the changes to the docstring of the ReferencedImageSequence (which replace the previous versions that are basically wrong) and the addition of the from_sequence method for that class.
Should we break this into 2 PRs and get these changes merged ASAP?
| List[CodedConcept], | ||
| np.ndarray, | ||
| List[CodedConcept], | ||
| List[Union[ReferencedImageSequence, None]] |
There was a problem hiding this comment.
NB backwards incompatible change
We have submitted a Correction Proposal and are currently discussing it with the DICOM Standard Committee. cc @dclunie |
Co-authored-by: Markus D. Herrmann <[email protected]>
Co-authored-by: Markus D. Herrmann <[email protected]>
Use deepcopy for CodedConcept.from_dataset()
Make pylibjpeg-libjpeg optional
Add warning when empty segmentation is passed with omit_empty_frames
Co-authored-by: Chris Bridge <[email protected]>
…ub:herrmannlab/highdicom into enhancement/annotations-intensity-measurements
Co-authored-by: Chris Bridge <[email protected]>
In case of intensity measurements for annotations, the microscopy image (and the optical path) need to be specified for the measurements. This PR adds allows including a reference to the images to which the measurements apply.
cc @dclunie