Minor fixes to segmentation #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPBridge
commented
Aug 14, 2022
Comment on lines
-576
to
-580
| if pixel_array.shape[1:3] != (self.Rows, self.Columns): | ||
| raise ValueError( | ||
| 'Pixel array representing segments has the wrong number of ' | ||
| 'rows and columns.' | ||
| ) |
There was a problem hiding this comment.
This is true by construction of the self.Rows and self.Columns, so the check is pointless
CPBridge
commented
Aug 14, 2022
Comment on lines
-571
to
-572
| if pixel_array.ndim == 2: | ||
| pixel_array = pixel_array[np.newaxis, ...] |
There was a problem hiding this comment.
This is duplicated from above
CPBridge
commented
Aug 14, 2022
Comment on lines
-573
to
-574
| if pixel_array.ndim not in [3, 4]: | ||
| raise ValueError('Pixel array must be a 2D, 3D, or 4D array.') |
There was a problem hiding this comment.
Moving this earlier simplifies things a bit
hackermd
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was reviewing #184 I noticed some minor errors in the implementation of segmentation. Just some checks that are redundant and make the code more confusing to follow as well as the typo you found in the examples. I thought I might as well push these now
@hackermd