misc: added OIDC error and edge-case handling #2708

sheensantoscapadngan · 2024-11-08T13:44:09Z

Description 📣

shows SMTP errors to the OIDC error callback page for immediate feedback
ensures that OIDC cannot be enabled when SMTP is not confirmed to be good
updates bootstrap SMTP check to display the actual error
ensures that user can login with OIDC if user account is previously created using org invite flow

# Here's some code block to paste some code snippets

I have read the contributing guide, agreed and acknowledged the code of conduct. 📝

maidul98

looks good, just left one comment

backend/src/ee/services/oidc/oidc-config-service.ts

maidul98

left one comment

misc: added more error handling

8a14914

sheensantoscapadngan marked this pull request as draft November 8, 2024 15:15

sheensantoscapadngan added 2 commits November 9, 2024 00:38

misc: made users automatically verified

9e4b66e

misc: finalized user messages

3f6a0c7

sheensantoscapadngan marked this pull request as ready for review November 8, 2024 17:51

sheensantoscapadngan requested a review from maidul98 November 13, 2024 17:25

maidul98 reviewed Nov 15, 2024

View reviewed changes

backend/src/ee/services/oidc/oidc-config-service.ts Outdated Show resolved Hide resolved

maidul98 previously approved these changes Nov 18, 2024

View reviewed changes

misc: added message for bypass

089a7e8

sheensantoscapadngan dismissed maidul98’s stale review via 089a7e8 November 18, 2024 09:29

maidul98 approved these changes Nov 18, 2024

View reviewed changes

maidul98 merged commit 6ff1602 into main Nov 18, 2024
4 checks passed