Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the wrong text is inserted after uploading an image #580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ppodds
Copy link

@ppodds ppodds commented Feb 16, 2024

πŸ”— Linked issue

Resolves #334. Resolves #574.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The original code inserted a link text after uploading the image. This pull request will correct it and ensure that the image name is respected when the file extension is included, particularly for known image extensions.

@erossini
Copy link

erossini commented Jul 1, 2024

I saw your code. Thank you, it fixed my issue. If you like, here the full code https://github.com/erossini/EasyMarkdownEditor

@ppodds
Copy link
Author

ppodds commented Sep 5, 2024

@Ionaru Do the PR can be merged?

@efficacy38
Copy link

+1

@ppodds ppodds requested a review from Ionaru October 18, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants