Feat/swerve #3
Merged
Feat/swerve #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't merge yet. going to delete the jank pathplanner stuff; leave empty slate for future dev |
audreypj
reviewed
Jan 12, 2024
There was a problem hiding this comment.
Changes look good but I think because you did swerve related stuff we should wait until it is tested on Saturday to merge into dev. I merged Derek and I's changes today which were really just removing pp errors (so mostly deleting stuff, you basically have the same changes here). So dev should be pretty good rn, and we can use this branch on Sat for swerve testing.
audreypj
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Phoenix 6 swerve builder, should function very similarly (for basic drive, not sure about odometry, have to look into that)
In order to get rid of unrelated errors to work on swerve I... very messily commented out/deleted the offending files. So, anything related to pathplanner had been commented out and it's very messy (like GOOD GOD is it messy). Should I just delete those files so later pathplanner developments can just fill them in?Deleted all pathplanner-related files, left a blank-ish slate for future development
Also not entirely sure about how good the swerve implementation is.