Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: set default type for parser #520

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

TelBotDev
Copy link

The value will be treated as str if there is no type. Then there will be error

Traceback (most recent call last):
  File "demo/visualize_result.py", line 144, in <module>
    query_indices = visualizer.vis_rank_list(args.output, args.vis_label, args.num_vis, args.rank_sort, args.label_sort, args.max_rank)
  File "./fastreid/utils/visualizer.py", line 158, in vis_rank_list
    query_indices = query_indices[:num_vis]
TypeError: slice indices must be integers or None or have an __index__ method

when we add some custom parameter, such as --num-vis 5

The value will be treated as `str` if there is no type. Then there will be error
```
Traceback (most recent call last):
  File "demo/visualize_result.py", line 144, in <module>
    query_indices = visualizer.vis_rank_list(args.output, args.vis_label, args.num_vis, args.rank_sort, args.label_sort, args.max_rank)
  File "./fastreid/utils/visualizer.py", line 158, in vis_rank_list
    query_indices = query_indices[:num_vis]
TypeError: slice indices must be integers or None or have an __index__ method
```
when we add some custom parameter, such as `--num-vis 5`
add actmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant