Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-11: Maximum call stack size exceeded with filters #12

Closed
wants to merge 2 commits into from
Closed

ISSUE-11: Maximum call stack size exceeded with filters #12

wants to merge 2 commits into from

Conversation

mrmlnc
Copy link
Collaborator

@mrmlnc mrmlnc commented Jan 28, 2018 •
edited
Loading

Links

What is?

  • So, just reduce context binding. The problem is that the context contains the entire current queue. Instead of binding a context, will pass it as a parameter.

@mrmlnc
chore(package): Just run «npm install»
d0f5c12
@mrmlnc
fix(directory-reader): Reduce context binding
e55ec5a 
The problem is that the context contains the entire current queue. Instead of binding a context, will pass it as a parameter.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.669% when pulling e55ec5a on mrmlnc:ISSUE-11_reduce_context_binding into 126bf8a on BigstickCarpet:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.669% when pulling e55ec5a on mrmlnc:ISSUE-11_reduce_context_binding into 126bf8a on BigstickCarpet:master.

@coveralls
Copy link

coveralls commented Jan 28, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 99.669% when pulling e55ec5a on mrmlnc:ISSUE-11_reduce_context_binding into 126bf8a on BigstickCarpet:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.669% when pulling e55ec5a on mrmlnc:ISSUE-11_reduce_context_binding into 126bf8a on BigstickCarpet:master.

@mrmlnc
Copy link
Collaborator Author

mrmlnc commented Jan 28, 2018

So, works for some cases, but not for all 😢

@mrmlnc mrmlnc closed this Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmlnc @coveralls