This repository has been archived by the owner on Mar 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Net Core 2.2, 3.0, 3.1 and Net Standard 2.1 targets #610
Open
TheXDS
wants to merge
20
commits into
JanKallman:master
Choose a base branch
from
TheXDS:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
354c844
REPAIRED METHOD - internal ExcelBorderItemXml Copy()
1ef3966
Add properties for image dimensions: Properties for a resized image's…
fb1f7e0
Prevent index out of array bounds exception
mason-mcglothlin 1ddba00
Fixed issue in formula match
leonardopinho f1e36ae
Fix issue #152 Posibility to ignore Microsoft Excel cells warning err…
romcode 03c8dca
Added async method one ExcelPackage
bhugot 2e140bb
changed FileStream creation
bhugot aa9e9ca
Add Net Core 2.2, 3.0, 3.1 and Net Standard 2.1 targets
TheXDS c51ce64
Removal of net35 target
TheXDS 1ff6e5d
Fixed problem with namespace prefix for sheetData tag in worksheet.
Michael-Greiner 0d692a2
Merge branch 'master' into master
TheXDS 4938e05
Removal of duplicate propertygroup for netstd2.1
TheXDS fe2a890
Merge pull request #1 from Michael-Greiner/master
TheXDS 1422d3a
Merge pull request #2 from bhugot/Async_Methods
TheXDS ad573a5
Merge pull request #3 from romcode/manage-cells-warning-errors
TheXDS e6e79bc
Merge pull request #4 from leonardopinho/master
TheXDS 7b48a5a
Merge pull request #5 from billgeek/MergeCellsFix
TheXDS d755ae1
Merge pull request #6 from mason-mcglothlin/master
TheXDS bf92ef1
Merge pull request #7 from PeterHevesi/ExcelBorderItemXml_Fix
TheXDS a277715
Minor compilation fixes
TheXDS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /******************************************************************************* | ||
| * Implemented following briddums advise ( https://stackoverflow.com/users/260473/briddums ), | ||
| * as himself explained in https://stackoverflow.com/questions/11858109/using-epplus-excel-how-to-ignore-excel-error-checking-or-remove-green-tag-on-t/14483234#14483234 | ||
| * The best way to address this issue is adding a whorksheet property that allows to ignore the warnings in a specified range. | ||
| *******************************************************************************/ | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using System.Xml; | ||
|
|
||
| namespace OfficeOpenXml | ||
| { | ||
| public class ExcelIgnoredError : XmlHelper | ||
| { | ||
| private ExcelWorksheet _worksheet; | ||
|
|
||
| /// <summary> | ||
| /// Constructor | ||
| /// </summary> | ||
| internal ExcelIgnoredError(XmlNamespaceManager ns, XmlNode node, ExcelWorksheet xlWorkSheet) : | ||
| base(ns, node) | ||
| { | ||
| _worksheet = xlWorkSheet; | ||
| } | ||
|
|
||
|
|
||
| public bool NumberStoredAsText | ||
| { | ||
| get | ||
| { | ||
| return GetXmlNodeBool("@numberStoredAsText"); | ||
| } | ||
| set | ||
| { | ||
| SetXmlNodeBool("@numberStoredAsText", value); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| public bool TwoDigitTextYear | ||
| { | ||
| get | ||
| { | ||
| return GetXmlNodeBool("@twoDigitTextYear"); | ||
| } | ||
| set | ||
| { | ||
| SetXmlNodeBool("@twoDigitTextYear", value); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| public string Range | ||
| { | ||
| get | ||
| { | ||
| return GetXmlNodeString("@sqref"); | ||
| } | ||
| set | ||
| { | ||
| SetXmlNodeString("@sqref", value); | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you want to target netstandard2.1 and netstandard2.0? Wouldn't it just be better to keep the lower version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about it, but ultimately decided to add several different targets because some projects I've seen or worked on do target them directly. For instance, I was unable to use any version of EPPlus on .Net Core 3.1 (the project required the use of .Net Core 3.1 because WPF and XAML Islands)
About netstandard2.1 and 2.0: Microsoft recommends that any new .Net project should target either the latest .Net Core release (3.1) or the latest .Net Standard release (2.1), and discourages targeting older frameworks, unless necessary. But still, I've found issues trying to make EPPlus (both .Net Core 2.1 and .Net Standard 2.0) work on newer targets. So, to properly cover as much platforms as possible, I decided to directly target them in the .csproj file, without sacrificing existing projects that may depend on a specific framework version.
Also, I think that nstd2.1 is basically nc3.0 without Microsoft-specific stuff, nstd2.0 was based of nc2.0, and nc2.2 and 3.0 are actually, really different. It was just to be sure that it would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think multi-targeting the various net core versions makes a lot of sense. I had just not considered targeting multiple net standard versions before. But with netstandard likely going away with dotnet 5, this may be an unnecessary concern.