Fixing artifacts downloading logging #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extractor/src/main/scala-sbt-1.3/sbt/jetbrains/keysAdapterEx.scala
Outdated
Show resolved
Hide resolved
extractor/src/main/scala-sbt-1.3/sbt/jetbrains/LogDownloadArtifacts.scala
Outdated
Show resolved
Hide resolved
extractor/src/main/scala-sbt-0.13/sbt/jetbrains/LogDownloadArtifacts.scala
Outdated
Show resolved
Hide resolved
extractor/src/main/scala-sbt-1.3/sbt/jetbrains/keysAdapterEx.scala
Outdated
Show resolved
Hide resolved
azdrojowa123
reviewed
Apr 4, 2024
extractor/src/main/scala-sbt-0.13/sbt/jetbrains/LogDownloadArtifacts.scala
Outdated
Show resolved
Hide resolved
azdrojowa123
reviewed
Apr 4, 2024
extractor/src/main/scala/org/jetbrains/sbt/StructurePlugin.scala
Outdated
Show resolved
Hide resolved
Sa1to
force-pushed
the
fix/SCL-22163
branch
2 times, most recently
from
534939f
to
1bfb828
Compare
extractor/src/main/scala-sbt-0.13/sbt/jetbrains/LogDownloadArtifacts.scala
Outdated
Show resolved
Hide resolved
extractor/src/main/scala-sbt-1.3/sbt/jetbrains/keysAdapterEx.scala
Outdated
Show resolved
Hide resolved
|
Thanks for the contribution! Please append YouTrack id tag in the commit messages ( |
azdrojowa123
approved these changes
Apr 12, 2024
unkarjedy
reviewed
Apr 12, 2024
|
I created a tag, and release new version 2024.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am assigning custom implementation of
CacheLoggertocsrLoggerbecause sbt implementation is not properly used inintellij-scalaplugin's sbt shell. Moreover it is only logging downloaded artifacts urls in debug level and it is not logging when downloading is started, only when its finished.For logging downloading artifacts in sync window we need to add task
LogDownloadArtifactsbecause it is not aware ofcsrLoggerglobal setting, and pass it viaapplycommand inintellij-scalaplugin.Screen.Recording.2024-04-05.at.10.58.41.mov
Screen.Recording.2024-04-05.at.11.00.05.mov