Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dynamic (ssconf://) key name by "name" field in its JSON #1561

Open
rorosin opened this issue Jul 9, 2024 · 4 comments
Open

Set dynamic (ssconf://) key name by "name" field in its JSON #1561

rorosin opened this issue Jul 9, 2024 · 4 comments
Labels
client feature request New feature or request

Comments

@rorosin
Copy link

rorosin commented Jul 9, 2024

Will there be feature to set client key name from dynamic key?

I do know that you can set client key name by hash part of url, but name field in json key would be cool for providers (e.g. to display there some info for key, cause now AFAIK it only supported by error message field)

@sbruens sbruens added client feature request New feature or request labels Jul 30, 2024
@murka
Copy link
Contributor

murka commented Sep 2, 2024

Hey, this is LGTM, I'll be working on the feature.

@fortuna
Copy link
Collaborator

fortuna commented Sep 3, 2024

@murka provided more context about the feature request:

So, the existing hash system is not dynamic for key names, I gonna use this feature for information user, for example:

  1. Quota in GB
  2. Subscription info

The current hash system is not working for this use cases.

I don't think hacking the name is a good idea. It can be very confusing to the user if the server name changes.

Instead, we need a more focused feature. Perhaps a message field that can be surfaced in the UI. Or something more focused on reporting quotas.

There's also a possible discussion on whether this should be on the dynamic key, or a client API backend, so that static keys can be supported as well.

@murka
Copy link
Contributor

murka commented Sep 3, 2024

Let's discuss about this feature.

So, I guess we need to provide a new property for the subtitles of the name keys.

@rorosin
Copy link
Author

rorosin commented Sep 8, 2024

new property for the subtitles of the name keys

Yeah, it would be great!

VPN providers could simply put in there traffic usage or key expiration date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants