Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): dynamic name for dynamic keys #2195

Closed
wants to merge 1 commit into from

Conversation

murka
Copy link

@murka murka commented Sep 2, 2024

@murka murka requested a review from a team as a code owner September 2, 2024 19:35
@murka
Copy link
Author

murka commented Sep 2, 2024

So, initial idea it was fetch and store keys name before connecting, but I have another idea, what about if hash-name is will be primary name, and we will take dynamic-key-name by fetch for each of session?

@murka
Copy link
Author

murka commented Sep 2, 2024

wdyt: @fortuna @daniellacosse @sbruens @jyyi1

@murka murka changed the title feat: dynamic name for dynamic keys feat(client): dynamic name for dynamic keys Sep 2, 2024
@fortuna
Copy link
Collaborator

fortuna commented Sep 3, 2024 via email

@murka
Copy link
Author

murka commented Sep 3, 2024

So, the existing hash system is not dynamic for key names, I gonna use this feature for information user, for example:

  1. Quota in GB
  2. Subscription info

The current hash system is not working for this use cases.

image

@fortuna
Copy link
Collaborator

fortuna commented Sep 3, 2024

I see. So the feature you really need is a way to communicate quota usage! Or perhaps a generic message.
I think it would be better to have a focused feature rather than hack the name. Changing the name of an existing service can be very confusing! Let's discuss in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants