[release-0.2] feat: add way to register post-__init__ callbacks #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
approved these changes
Oct 11, 2023
mortenpi
added a commit
that referenced
this pull request
Nov 30, 2023
[Diff since v0.2.9](v0.2.9...v0.2.10) **Merged pull requests:** - [release-0.2] feat: add way to register post-__init__ callbacks (#65) (@mortenpi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
register_post_init_callbackfunction that can be used to register callbacks that are guaranteed to be called afterDataSets.__init__()has run (critically, including in sysimages). Unfortunately, I can't really think of a easy way to test the queueing, since even in a sysimage, but it seems to work correctly.This PR is directly against
release-0.2and bumps the version as well. Will forward-port this to master in a separate PR.