Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remvoe all getproperty funcs #99

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

inkydragon
Copy link
Collaborator

Close #77

I've checked all SHA2_CTX and SHA3_CTX subtypes usage by using JuliaHub.

Only a few packages use SHA.jl directly.
All packages use only the exported API.
So it seems safe to remove this code.

To be on the safe side, we could run pkg-eval the next time you update the SHA version in julia.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ab324c) 99.79% compared to head (63817ab) 99.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   99.79%   99.78%   -0.01%     
==========================================
  Files           9        9              
  Lines         490      468      -22     
==========================================
- Hits          489      467      -22     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@staticfloat staticfloat merged commit da351bb into JuliaCrypto:master Apr 23, 2024
11 checks passed
@inkydragon inkydragon deleted the rm-getproperty branch April 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Base.getproperty
3 participants