IIR equalizer biquad filters #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to see these filters in DSP.jl. One style comment - I think it might be nicer to have separate functions for the different filter types rather than a string argument. Perhaps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a function for direct design of typical IIR equalizer filters. It is based on the formula and derivations from the DAFx book (Zölzer, 2011). Available filter types are lowpass, highpass, bandpass, bandstop, low shelving, high shelving and peak.
Please review and tell me if you think this is interesting for inclusion into the main branch and if changes are required. If you consider merging, I will also add a few tests...