Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add modes to conv function #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasonsychau
Copy link

add modes to conv function

@galenlynch
Copy link
Member

galenlynch commented Aug 4, 2019

This is a very big change to how conv works with no explanation. Besides changing convolution from frequency domain to time domain, and thereby changing its algorithmic complexity, this commit would also make conv no longer work with arbitrary dimensions (and instead only work with vectors), as well as no longer accepting inputs with arbitrary indexing (and instead only work with arrays that start at index one).

Supporting something like Matlab's convolution modes could be done just by cropping the output of conv. If you want to support these modes at the library level, then that seems like a better place to start.

Copy link
Member

@galenlynch galenlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to add this functionality, please implement it in a way that preserves the existing functionality and performance.

@jasonsychau
Copy link
Author

Sure, I’ll review at later time.

Thanks, Jason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants