Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-argument convolution #338

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

N-argument convolution #338

wants to merge 34 commits into from

Commits on May 15, 2019

  1. Overlap-save convolution

    I have added an overlap-save algorithm to convolution, which is substantially
    faster (~2x) for large convolution problems. It is also substantially faster
    than other packages like ImageFiltering.jl. For smaller convolutions, it is
    about the same or a little bit slower than standard fft convolution. The cutoff
    between overlap-save and simple fft convolution is pretty arbitrary at the
    moment, so it would be nice to add some benchmarking to allow DSP.jl to choose
    between the two algorithms depending on the size of the input. It would also be
    nice to add spatial/time domain filtering for small convolutions, as it would
    almost certainly be faster than fft convolutions. This is relevant to JuliaDSP#224.
    galenlynch committed May 15, 2019
    Configuration menu
    Copy the full SHA
    18ddeb1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3fd184d View commit details
    Browse the repository at this point in the history
  3. Lots of sign posting

    galenlynch committed May 15, 2019
    Configuration menu
    Copy the full SHA
    238472f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e10f3da View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a6c15a1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b875894 View commit details
    Browse the repository at this point in the history
  7. Simplify Val construction

    galenlynch committed May 15, 2019
    Configuration menu
    Copy the full SHA
    c766520 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    08bcd80 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    01b637b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7bf3c6d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    92549ba View commit details
    Browse the repository at this point in the history
  12. Remove redundant test

    galenlynch committed May 15, 2019
    Configuration menu
    Copy the full SHA
    817f44d View commit details
    Browse the repository at this point in the history

Commits on May 18, 2019

  1. Configuration menu
    Copy the full SHA
    38bfd03 View commit details
    Browse the repository at this point in the history
  2. implement N-argument convolution

    performs overlap-save on the first argument if it is large
    enough to warrant it. Performs fft convolution of all others.
    HDictus committed May 18, 2019
    Configuration menu
    Copy the full SHA
    7fb9548 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. remove print statements

    HDictus committed May 21, 2019
    Configuration menu
    Copy the full SHA
    849dfab View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. Reduce diff noise

    galenlynch committed May 28, 2019
    Configuration menu
    Copy the full SHA
    e27d5b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b226eec View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. some of the review advice...

    public conv needs 2 or more arguments
    redundant union removed
    permsort with rev=true
    comprehension replaced with elementwise operation
    HDictus committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    5f949d4 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2019

  1. comment out sorting for now

    (fix minor issue)
    HDictus committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    9b31146 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. Configuration menu
    Copy the full SHA
    354fbc8 View commit details
    Browse the repository at this point in the history
  2. add some larger convolutions to test

    also fix issue that test revealed
    HDictus committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    715dd9f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    680a371 View commit details
    Browse the repository at this point in the history
  4. dispatch one and more to different filter transforms

    copy only out array for complex
    HDictus committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    3a3b99f View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Configuration menu
    Copy the full SHA
    09e8ed2 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Configuration menu
    Copy the full SHA
    aa40c8e View commit details
    Browse the repository at this point in the history
  2. move compat into deps

    HDictus committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    1fc71f4 View commit details
    Browse the repository at this point in the history
  3. commit hash for compat

    HDictus committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    e03a5ac View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    86e6938 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    66b187a View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. add missing end

    HDictus committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    0441b19 View commit details
    Browse the repository at this point in the history
  2. Test that old-style seperable convolution warns about the change

    and test that it runs an ordinary convolution
    HDictus committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    9f5c11c View commit details
    Browse the repository at this point in the history
  3. test_warn syntax

    HDictus committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    6d4916f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5924133 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Configuration menu
    Copy the full SHA
    feac1c7 View commit details
    Browse the repository at this point in the history