Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #235 #237

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Resolve #235 #237

merged 2 commits into from
Aug 14, 2023

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Aug 14, 2023

I think this fixes the aforementioned issue. Closes #235

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (105290f) 84.79% compared to head (2c6b00a) 84.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   84.79%   84.81%   +0.01%     
==========================================
  Files          18       18              
  Lines        1934     1936       +2     
==========================================
+ Hits         1640     1642       +2     
  Misses        294      294              
Files Changed Coverage Δ
src/derivatives/linalg/arithmetic.jl 72.53% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willtebbutt!

@willtebbutt willtebbutt merged commit 6c7b9cf into master Aug 14, 2023
6 checks passed
@willtebbutt willtebbutt deleted the wct/fix-bug branch August 14, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Derivative of transposed-vector times matrix is incorrect.
2 participants