Allow per-request setting of options on the Curl easy_handle #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows any of the more esoteric CURL options to be applied as necessary on a per-request basis.
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 92.77% 93.00% +0.23%
==========================================
Files 5 5
Lines 498 515 +17
==========================================
+ Hits 462 479 +17
Misses 36 36
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows any of the more esoteric CURL options to be applied as necessary on a per-request basis.
This is the bare-bones approach to fixing #141 which I'm using in HTTPDownloads.jl (I had to vendor parts of Downloads to do that).
I can go ahead and add tests / docs if this seems like the right approach.
The thing I don't love about exposing the easy handle as part of the official API as it ties this package more closely with libcurl at an API level. Perhaps that's mostly solvable with documentation though + exposing more of the commonly needed operations so people don't need the escape hatch.