Fix artifact directories not having traversal permissions #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
added a commit
to JuliaLang/julia
that referenced
this pull request
Nov 5, 2024
It turns out that Windows requires the executable bit set if the `BYPASS_TRAVERSE_CHECKING` privilege is not attached to a user's account. It's simply more correct to ensure that our directories have this bit set, and unfortunately our `filemode()` function call is not complete on Windows and does not include this bit, so we manually add it in on Windows.
staticfloat
force-pushed
the
sf/windows_executable_bit
branch
from
8f3bb7a
to
d7ba620
Compare
|
Is this related to JuliaLang/julia#52272? |
|
It may not fix all cases, but it is one way such issues arise. |
|
Should we also be setting this bit on directories in Tar.extract? |
|
In my tests, Tar.extract didn’t set any permissions on directories on windows. |
|
Shall we merge this and have it backported to the upcoming 1.10.7 (if there is still time?) and 1.11 as well? |
|
Why are we still modifying file permissions on Windows at all? I'm still completely convinced that we should do absolutely nothing to modify file permissions on Windows systems, see JuliaLang/julia#52272 (comment) for my explanation of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that Windows requires the executable bit set if the
BYPASS_TRAVERSE_CHECKINGprivilege is not attached to a user's account. It's simply more correct to ensure that our directories have this bit set, and unfortunately ourfilemode()function call is not complete on Windows and does not include this bit, so we manually add it in on Windows.