Add the option to ignore ConvergenceExceptions (#233)
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of a non-converged model might still be interesting. However, since `ConvergenceExceptions` are thrown these partially fitted models are discarded. This commit adds a `omit_convergence_exception` argument to all relevant functions that allows the user to omit such exceptions and return the partially trained model. The exception is still thrown in the default case to preserve backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of a non-converged model might still be interesting. However, since
ConvergenceExceptionsare thrown, these partially fitted models are discarded.This commit adds a
omit_convergence_exceptionargument to all relevant functions that allows the user to omit such exceptions and return the partially trained model. The exception is still thrown in the default case to preserve backwards compatibility.