Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] improve test quality #61

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] improve test quality #61

wants to merge 2 commits into from

Conversation

johnnychen94
Copy link
Member

This is a base branch for future PRs.

This only organizes codes without any modification on the test cases
@johnnychen94 johnnychen94 changed the title [WIP] increase test quality [WIP] improve test quality Jul 6, 2020
* rename _convert to maybe_encode
* add tests for maybe_encode
* ignore CRLF/LF differences

Co-authored-by: Lyndon White <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant