Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Facebook Count #296

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Facebook Count #296

wants to merge 2 commits into from

Conversation

njt1982
Copy link

@njt1982 njt1982 commented Aug 22, 2016

Applying fix from #294 by @sphism

@@ -24,7 +24,7 @@ SharrrePlatform.register("facebook", function (options) {
return {
settings: defaultSettings,
url: function (url) {
return "https://graph.facebook.com/fql?q=SELECT%20url,%20normalized_url,%20share_count,%20like_count,%20comment_count,%20total_count,commentsbox_count,%20comments_fbid,%20click_count%20FROM%20link_stat%20WHERE%20url=%27{url}%27&callback=?";
return "http://graph.facebook.com/?id={url}&callback=?";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be https...

@sphism
Copy link
Contributor

sphism commented Aug 22, 2016

Cheers mate

@aandrewjoyce
Copy link

Still showing up issues on my end after replacing the minified file in production.

@njt1982
Copy link
Author

njt1982 commented Aug 23, 2016

@aandrewjoyce any errors in console? What happens in the network tab? What's the production URL?

(It's a little hard to debug/help without any more info).

@sphism
Copy link
Contributor

sphism commented Aug 23, 2016

@AlainVagner
Copy link

on my side, the call was done correctly to facebook, but the info was not displayed.
I have found that on some browsers, testing that the resulting json.share object was not empty using json.share.length > 0 was not working.
Please see this change https://github.com/AlainVagner/Sharrre/commit/59528271500bd8e7ddf1aff20bc5799a65c7d00a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants