refactor(ui): Use AutoMirrored icons and migrated deprecated components #1631
Conversation
This commit updates several icons to use their AutoMirrored counterparts for better right-to-left language support
This commit migrates the UI components that has been deprecated in the latest versions of Material 3: - Replaced `Divider` with `HorizontalDivider`. - Updated `ExposedDropdownMenuBox` to use `MenuAnchorType`. - Added `progress` lambda to `CircularProgressIndicator`. - Updated `HorizontalPagerIndicator` syntax. - Added animation to `DialogCheckBoxItem`. - Updated `LinearProgressIndicator` syntax. - Replaced `AlertDialog` with `BasicAlertDialog`. - Replaced `ClickableText` with `Text` and `AnnotatedString` with links. --- - HorizontalPagerIndicator has to be updated
why? |
It's not necessary, but deprecated by the Accompanist library (like almost everything in there) |
| @@ -212,22 +213,27 @@ fun AutoUpdateUnavailableDialog(onDismissRequest: () -> Unit = {}) { | |||
| ) | |||
|
|
|||
| val annotatedString = buildAnnotatedString { | |||
| append(text) | |||
| append(text.substring(0, text.indexOf(hyperLinkText))) | |||
There was a problem hiding this comment.
what if the hyperLinkText is not at the end of the text?
There was a problem hiding this comment.
Since the hyperLinkText is being a parameter for another string there is no other way than doing a substring for putting the style and click listening in the new implementation.
In this case I believe that the current implementation is well done. Modifying the string resource is not viable. Any ideas are welcome.
There was a problem hiding this comment.
This is the only thing I think that might be okay, but tell me some other options If you are not comfortable with the changes and I'll do them. Thanks!
val annotatedString = buildAnnotatedString {
append(text.substring(0, text.indexOf(hyperLinkText)))
withLink(
LinkAnnotation.Clickable(
tag = "Link to the latest app release in GitHub",
styles = TextLinkStyles(
SpanStyle(
color = MaterialTheme.colorScheme.tertiary,
textDecoration = TextDecoration.Underline,
)
),
linkInteractionListener = { _ ->
uriHandler.openUri("https://github.com/JunkFood02/Seal/releases/latest")
hapticFeedback.performHapticFeedback(HapticFeedbackType.LongPress)
}
)
) {
append(hyperLinkText)
}
}There was a problem hiding this comment.
not really understand what you meant on this:
- There's an
addLink()which is a drop-in replacement of theaddUrlAnnotationhere - If you'd go with
withLink(), you should append the rest of thetextwhich is after thehyperLinkText(if exist)
append(text.substring(0, startIndex))
//...
append(hyperLinkText)
//...
append(text.substring(endIndex, text.length))| } | ||
| ) | ||
| ) { | ||
| append(text.substring(startIndex, endIndex)) |
This PR updates several icons to use their AutoMirrored counterparts for better right-to-left language support. It also updates all the deprecated UI components to use their new implementations.
HorizontalPagerIndicatorstill needs to be migrated, but Google hasn't updated it, so an own-implementation may be needed