Use theforeman-rubocop gem #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris1984
requested changes
May 28, 2024
chris1984
requested changes
Jun 7, 2024
chris1984
requested changes
Jun 10, 2024
There was a problem hiding this comment.
@archanaserver acked your other pr, can you rebase this one to resolve the conflicts
Choose to inherit from lenient.yml, because wanted to inherit rules from style_lenient.yml as well, i followed this: https://github.com/theforeman/theforeman-rubocop?tab=readme-ov-file#not-intrusive-style---lenient Also drop some cops from the .rubocop.yml config, because that was present in inherit-gem and added theforeman-rubocop gem. This is part of Rubocop standerdization, link for the reference: https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239
|
Thanks @chris1984 and this one is green now! |
chris1984
approved these changes
Jun 11, 2024
ekohl
reviewed
Aug 21, 2024
| @@ -65,6 +65,8 @@ Gem::Specification.new do |gem| | |||
| gem.version = HammerCLIKatello.version | |||
| gem.required_ruby_version = '>= 2.7', '< 3.2' | |||
|
|
|||
| gem.add_dependency 'theforeman-rubocop', '~> 0.1.0' | |||
There was a problem hiding this comment.
This should have been a development dependency, not a runtime dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose to inherit from lenient.yml, because wanted to inherit rules from style_lenient.yml as well, i followed this:
https://github.com/theforeman/theforeman-rubocop?tab=readme-ov-file#not-intrusive-style---lenient
Also drop some cops from the .rubocop.yml config, because that was present in inherit-gem and added theforeman-rubocop gem.
This is part of Rubocop standerdization, link for the reference: https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239