Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT REVIEW: ZND build with unlimited point always on #1681

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nicolecomputer
Copy link
Contributor

Summary:

DO NOT REVIEW

Test plan:

  • Build a ZND

@nicolecomputer nicolecomputer self-assigned this Sep 26, 2024
@khan-actions-bot khan-actions-bot requested a review from a team September 26, 2024 18:41
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to README.md, .changeset/gentle-shirts-kiss.md, packages/perseus/src/widgets/interactive-graph.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (05580ac) and published it to npm. You
can install it using the tag PR1681.

Example:

yarn add @khanacademy/perseus@PR1681

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1681

Copy link
Contributor

Size Change: -5 B (0%)

Total Size: 862 kB

Filename Size Change
packages/perseus/dist/es/index.js 417 kB -5 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 279 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.4 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@jeremywiebe
Copy link
Collaborator

FWIW, we recently changed the snapshot build process to also build for drafts. So you could mark this as a draft if that makes things more obvious to prevent folks reviewing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants