Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Locked Figures Aria] Use TextArea instead of TextField #1706

Merged
merged 20 commits into from
Sep 30, 2024
Merged

[Locked Figures Aria] Use TextArea instead of TextField #1706

merged 20 commits into from
Sep 30, 2024

Commits on Sep 26, 2024

  1. [Locked Figure Aria] Implement locked point aria label behavior on graph

    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4632687 View commit details
    Browse the repository at this point in the history

  2. [Locked Figures Aria] Add/edit/delete locked point aria label

    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3dd3251 View commit details
    Browse the repository at this point in the history

  3. Keep text field there at all times

    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    53acecf View commit details
    Browse the repository at this point in the history

  4. Break out the aria section into its own component. Add tooltip.

    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e15d264 View commit details
    Browse the repository at this point in the history

  5. changeset

    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    10a8d55 View commit details
    Browse the repository at this point in the history

  6. Add test for undefined

    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e099b44 View commit details
    Browse the repository at this point in the history

  7. [Locked Figure Aria] Implement locked line aria label behavior on graph

    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fd3875e View commit details
    Browse the repository at this point in the history

  8. [Locked Figure Aria] Locked line aria label editor UI

    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6340759 View commit details
    Browse the repository at this point in the history

  9. [Locked Figure Aria] Implement locked vector aria labels (graph + edi… 

    …tor)
    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1003256 View commit details
    Browse the repository at this point in the history

  10. [Locked Figure Aria] Implement locked ellipse aria labels (graph + ed… 

    …itor)
    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3c48adc View commit details
    Browse the repository at this point in the history

  11. streamline commas

    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    111505f View commit details
    Browse the repository at this point in the history

  12. [Locked Figure Aria] Locked function aria labels (graph + editor)

    @nishasy
    nishasy committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f5ac0a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. [Locked Figure Labels] View locked polygon labels

    @nishasy
    nishasy committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e153641 View commit details
    Browse the repository at this point in the history

  2. [Locked Figure Labels] Add/edit/delete locked polygon labels

    @nishasy
    nishasy committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    dad7ee5 View commit details
    Browse the repository at this point in the history

  3. [Locked Figure Aria] Locked polygon aria labels (graph + editor)

    @nishasy
    nishasy committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    127b0e9 View commit details
    Browse the repository at this point in the history

  4. [Locked Figure Labels] Add color select to locked figure labels settings

    @nishasy
    nishasy committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0e571ae View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge branch 'main' into locked-figure-label-colors

    @nishasy
    nishasy committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e297f3d View commit details
    Browse the repository at this point in the history

  2. [Locked Figures Aria] Use TextArea instead of TextField 

    Replace LabeledTextField with TextArea in `locked-figures-aria-tsx`
so that multiline aria labels are easier to work with.

Issue: none

Test plan:
`yarn jest`

Storybook
- http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-figure-labels-all-flags
- All the locked figure types should have updated aria label fields.
    @nishasy
    nishasy committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9fe4aea View commit details
    Browse the repository at this point in the history

  3. changeset

    @nishasy
    nishasy committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7e2b026 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into locked-figures-aria-textarea

    @nishasy
    nishasy authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    46a5888 View commit details
    Browse the repository at this point in the history