Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to event details fired from interactive graph. #1723

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

catandthemachines
Copy link
Member

Summary:

Missing two addtional event details fired from interactive graph

Issue: LEMS-2324

Test plan:

N/A

@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Oct 3, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/lovely-ants-itch.md, packages/perseus-core/src/analytics.ts, packages/perseus/src/widgets/interactive-graphs/mafs-graph.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (50461b4) and published it to npm. You
can install it using the tag PR1723.

Example:

yarn add @khanacademy/perseus@PR1723

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1723

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Size Change: +25 B (0%)

Total Size: 866 kB

Filename Size Change
packages/perseus/dist/es/index.js 419 kB +25 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 280 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.4 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Contributor

@SonicScrewdriver SonicScrewdriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM :)

@catandthemachines catandthemachines merged commit d4f4e2b into main Oct 4, 2024
9 checks passed
@catandthemachines catandthemachines deleted the cajohnson/event-fix branch October 4, 2024 00:10
Copy link
Collaborator

@jeremywiebe jeremywiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catandthemachines Sorry that I missed this before you landed it. We need to fix the values passed to widgetType and widgetId :)

Comment on lines +124 to +125
widgetType: "INTERACTIVE_GRAPH",
widgetId: "interactive-graph",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this isn't right. The widgetType should be interactive-graph (unfortunately, Perseus uses name and widgetType in different places, they're the same concept) and widgetId is typically something like interactive-graph 1.

It looks like we pass down the widgetId (which is a part of the WidgetProps type.

We don't define that prop on the StatefulMafsGraphProps type, but it's definitely passed down.

We'll need to update this to pass the actual widgetId so that our analytics data is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants