Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fei5815.1.excludebuildinfo] Add .npmignore file #1022

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

somewhatabstract
Copy link
Member

Summary:

This adds an .npmignore file to the project to exclude unnecessary files from the published package. Any files declaration in a package.json will override this, so that's something to watch out for, but this is sufficient for now.

Issue: FEI-5815

Test plan:

  1. yarn
  2. yarn build
  3. yarn build:types
  4. rm .npmignore
  5. cd packages/wonder-stuff-server
  6. npm pack --dry-run
  7. Observe that the tsconfig-build.json and tsconfig-build.tsbuildinfo are included
  8. cd ../..
  9. git checkout .npmignore
  10. cd packages/wonder-stuff-server
  11. npm pack --dry-run
  12. Observe that the tsconfig-build.json and tsconfig-build.tsbuildinfo are not included

@somewhatabstract somewhatabstract self-assigned this Aug 28, 2024
@somewhatabstract somewhatabstract requested a review from a team August 28, 2024 21:06
Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 0c436ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@khanacademy/wonder-stuff-ci Patch
@khanacademy/wonder-stuff-core Patch
@khanacademy/wonder-stuff-i18n Patch
@khanacademy/wonder-stuff-render-environment-jsdom Patch
@khanacademy/wonder-stuff-render-server Patch
@khanacademy/wonder-stuff-sentry Patch
@khanacademy/wonder-stuff-server Patch
@khanacademy/wonder-stuff-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team August 28, 2024 21:06
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Aug 28, 2024

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .npmignore, .changeset/six-chefs-doubt.md

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

Size Change: 0 B

Total Size: 4.63 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.85 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.65 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 1.12 kB

compressed-size-action

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (509c2a5) to head (0c436ee).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1022   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          97       97           
  Lines        1392     1392           
  Branches      358      359    +1     
=======================================
  Hits         1390     1390           
  Misses          1        1           
  Partials        1        1           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 509c2a5...0c436ee. Read the comment docs.

@somewhatabstract somewhatabstract merged commit 4fb7745 into main Aug 29, 2024
6 checks passed
@somewhatabstract somewhatabstract deleted the fei5815.1.excludebuildinfo branch August 29, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants