Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fei5402.1.node20workflows] Change workflows to node 20 #990

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

somewhatabstract
Copy link
Member

Summary:

This updates our Wonder Blocks workflows to use Node 20.

In order to verify things, I learned some additional steps for macOS.

  1. Switch to node 20 (I use NVM, so nvm use 20)
  2. Run yarn or yarn install
  3. If you get an error about node-gyp. You either need to install XCode command line tools (You can do this by running xcode-select --install and following the prompts), or switch to use those tools from your version of XCode (XCode 14.3.1 appears to cause a lot of errors) - you can do this by running sudo xcode-select -s /Library/Developer/CommandLineTools.
  4. Re-run yarn or yarn install after this and all should be well.

Issue: FEI-5402

Test plan:

See above steps to get things installed properly for macOS.

I then ran:

  • yarn test
  • yarn lint
  • yarn typecheck
  • yarn build

@somewhatabstract somewhatabstract self-assigned this Dec 14, 2023
@somewhatabstract somewhatabstract requested a review from a team December 14, 2023 23:59
Copy link

changeset-bot bot commented Dec 14, 2023

🦋 Changeset detected

Latest commit: a3b0629

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team December 14, 2023 23:59
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Dec 14, 2023

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to package.json, yarn.lock, .changeset/sour-ties-agree.md, .github/workflows/node-ci-main.yml, .github/workflows/node-ci.yml, .github/workflows/release.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Size Change: 0 B

Total Size: 4.67 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.87 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.66 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 1.13 kB

compressed-size-action

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #990 (a3b0629) into main (f1cfdeb) will not change coverage.
Report is 70 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #990   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines         1393      1390    -3     
  Branches       359       343   -16     
=========================================
- Hits          1393      1390    -3     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4b0d9...a3b0629. Read the comment docs.

Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we're getting the node-gyp error here, as well, so I think this will require a more-systemic fix.

@somewhatabstract
Copy link
Member Author

It seems like we're getting the node-gyp error here, as well, so I think this will require a more-systemic fix.

There's a different issue for Linux than macOS. It'll need a different approach

@somewhatabstract
Copy link
Member Author

It seems like we're getting the node-gyp error here, as well, so I think this will require a more-systemic fix.

Ah this is a Python 3.12 issue where the distutils module is deprecated. This won't affect devs right now since we're using 3.11.

I'll work on a "fix" for workflows. Short term would be to use 3.11.

@somewhatabstract somewhatabstract merged commit d6296d4 into main Dec 19, 2023
8 checks passed
@somewhatabstract somewhatabstract deleted the fei5402.1.node20workflows branch December 19, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants