Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layers: Validate static accesses are not OOB #8347

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spencer-lunarg
Copy link
Contributor

This adds CPU side validation for basic OOB of indexing into descriptors

With the following logic

layout(set = 0, binding = 0, std140) buffer Block1 {
    int i_data[4];
    int o_data;
};
void main() {
    o_data = i_data[4];
}

we clearly can detect any chances of OOB because everything is constant

the goal of this is to make sure this is covered so another PR can remove expensive GPU-AV instrumentation on checking constants are OOB

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner August 1, 2024 17:26
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 227833.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17171 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17171 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 227855.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17172 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17172 passed.

@spencer-lunarg spencer-lunarg marked this pull request as draft August 2, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants